-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated to test-runner-image with go-v1.19 and bumped linter for chart #9055
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: longwuyuan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
% docker run -ti registry.k8s.io/ingress-nginx/e2e-test-runner:v20220823-ge19026fe4@sha256:038fc60379b6ce9a0134c2ff9134edccad1f8ecbd9c6ebed9660711d05b0ed95 go version |
There is go v1.19.1, maybe it is worth to update to this version. Also, maybe we can add in the image/build to verify go version and download some pinned version instead of relying on this being based on the e2e image, wdyt? |
@rikatz Will do exactly that.
Next, when I look now, it seems stopping to compile the binary of the controller called My thoughts are to bump to go v1.19.1 with current process so we can make the release with go v1.19.1 asap, along with the PSA, otel and other changes. Then some relative lack of pressure will exist to change the build system. But I will wait for advise/tips/info on changing the build system and do accordingly. |
Closing because we need #9057 so this PR becomes redundant |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
make
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook