Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to test-runner-image with go-v1.19 and bumped linter for chart #9055

Closed
wants to merge 1 commit into from
Closed

updated to test-runner-image with go-v1.19 and bumped linter for chart #9055

wants to merge 1 commit into from

Conversation

longwuyuan
Copy link
Contributor

@longwuyuan longwuyuan commented Sep 16, 2022

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

  • Its a bump so no new issue created directly but relates to several issues needing bump

How Has This Been Tested?

  • Tested locally with make

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

NONE 

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: longwuyuan
Once this PR has been reviewed and has the lgtm label, please assign rikatz for approval by writing /assign @rikatz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@longwuyuan
Copy link
Contributor Author

/triage accepted
/assign @tao12345666333 @rikatz @strongjz

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 16, 2022
@longwuyuan
Copy link
Contributor Author

% docker run -ti registry.k8s.io/ingress-nginx/e2e-test-runner:v20220823-ge19026fe4@sha256:038fc60379b6ce9a0134c2ff9134edccad1f8ecbd9c6ebed9660711d05b0ed95 go version
go version go1.18.2 linux/amd64
[~]
% docker run -ti registry.k8s.io/ingress-nginx/e2e-test-runner:v20220905-g79a311d3b@sha256:116f05f2cc293e96c9f4abd7f7add365fe23ceb85486fe94b973eddd75a76fbf go version
go version go1.19 linux/amd64

@rikatz
Copy link
Contributor

rikatz commented Sep 16, 2022

There is go v1.19.1, maybe it is worth to update to this version.

Also, maybe we can add in the image/build to verify go version and download some pinned version instead of relying on this being based on the e2e image, wdyt?

@longwuyuan
Copy link
Contributor Author

@rikatz Will do exactly that.

  • Close this PR
  • Bump go to v1.19.1 in the project

Next, when I look now, it seems stopping to compile the binary of the controller called nginx-ingress-controller using that test-runner image, requires a very big change to the entire build process. I think the volume of change required and the complexity of the change required will take significant amount of iterations. There may be nasty surprises too.

My thoughts are to bump to go v1.19.1 with current process so we can make the release with go v1.19.1 asap, along with the PSA, otel and other changes.

Then some relative lack of pressure will exist to change the build system.

But I will wait for advise/tips/info on changing the build system and do accordingly.

@longwuyuan
Copy link
Contributor Author

Closing because we need #9057 so this PR becomes redundant

@longwuyuan longwuyuan closed this Sep 16, 2022
@longwuyuan longwuyuan deleted the update-testrunner-image branch September 16, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants