Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stable.txt #8774

Closed
wants to merge 1 commit into from
Closed

update stable.txt #8774

wants to merge 1 commit into from

Conversation

strongjz
Copy link
Member

@strongjz strongjz commented Jul 2, 2022

Update stable.txt to match current stable version

/triage accepted
/priority backlog
/kind feature
/assign @rikatz @tao12345666333

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 2, 2022
@rikatz
Copy link
Contributor

rikatz commented Jul 3, 2022

/lgtm
/hold
Are we still using this?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 3, 2022
@strongjz
Copy link
Member Author

strongjz commented Jul 3, 2022

I thought jt was used for kind?

@tao12345666333
Copy link
Member

kind project no longer needs this configuration

kubernetes-sigs/kind#2368

@tao12345666333
Copy link
Member

tao12345666333 commented Jul 3, 2022 •
edited
Loading

But I think there should be value in keeping it for now.
(Not sure if other projects will depend on this configuration

/lgtm

UPDATE: After my quick search, I have yet to see a reference to this file in the public repo on GitHub

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, strongjz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [rikatz,strongjz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@strongjz
Copy link
Member Author

strongjz commented Jul 3, 2022

it was only used for kind, so if it doesn't need it lets remove it then.

@strongjz
Copy link
Member Author

strongjz commented Jul 3, 2022

closing this for #8775

/close

@k8s-ci-robot
Copy link
Contributor

@strongjz: Closed this PR.

In response to this:

closing this for #8775

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@strongjz strongjz deleted the update-stable branch July 3, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikatz rikatz Awaiting requested review from rikatz

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

@tao12345666333 tao12345666333

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strongjz @rikatz @tao12345666333 @k8s-ci-robot