Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v1.2.1 #8646

Merged
merged 2 commits into from
May 31, 2022
Merged

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented May 30, 2022

Signed-off-by: Jintao Zhang [email protected]

What this PR does / why we need it:

release v1.2.1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Jintao Zhang <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 30, 2022
@k8s-ci-robot
Copy link
Contributor

@tao12345666333: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2022
@k8s-ci-robot k8s-ci-robot added area/helm Issues or PRs related to helm charts approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2022
@tao12345666333 tao12345666333 changed the title chore: release v1.2.1 [WIP] chore: release v1.2.1 May 30, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
Signed-off-by: Jintao Zhang <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2022
@tao12345666333
Copy link
Member Author

/cc @rikatz @strongjz
/uncc @ChiefAlexander @ElvinEfendi

@k8s-ci-robot k8s-ci-robot requested review from rikatz and strongjz and removed request for ElvinEfendi and ChiefAlexander May 30, 2022 16:00
@tao12345666333 tao12345666333 changed the title [WIP] chore: release v1.2.1 chore: release v1.2.1 May 30, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
@tao12345666333
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 30, 2022
@strongjz
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: strongjz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [strongjz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c32f9a4 into kubernetes:main May 31, 2022
@blu3r4y
Copy link

blu3r4y commented Jun 27, 2022

This PR adds the text #GENERATED FOR K8S 1.20 on every second line in the YAML files, which is not very readable. Was this intended?

For example, have a look right here:

#GENERATED FOR K8S 1.20
apiVersion: v1
#GENERATED FOR K8S 1.20
kind: Namespace
#GENERATED FOR K8S 1.20
metadata:
#GENERATED FOR K8S 1.20
labels:
#GENERATED FOR K8S 1.20
app.kubernetes.io/instance: ingress-nginx
#GENERATED FOR K8S 1.20
app.kubernetes.io/name: ingress-nginx
#GENERATED FOR K8S 1.20
name: ingress-nginx
#GENERATED FOR K8S 1.20
---

rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
* chore: release v1.2.1

Signed-off-by: Jintao Zhang <[email protected]>

* chore: generate static yaml

Signed-off-by: Jintao Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants