Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to base image with LD_LIBRARY_PATH for opentelemetry #8635

Closed
wants to merge 2 commits into from
Closed

change to base image with LD_LIBRARY_PATH for opentelemetry #8635

wants to merge 2 commits into from

Conversation

longwuyuan
Copy link
Contributor

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #8634

How Has This Been Tested?

  • Will be tested in CI
  • Will attempt to make build image locally but that is not for all images

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 25, 2022
@k8s-ci-robot
Copy link
Contributor

@longwuyuan: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: longwuyuan
To complete the pull request process, please assign tao12345666333 after the PR has been reviewed.
You can assign the PR to them by writing /assign @tao12345666333 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/helm Issues or PRs related to helm charts label May 25, 2022
@k8s-ci-robot k8s-ci-robot requested review from cpanato and rikatz May 25, 2022 10:48
@longwuyuan
Copy link
Contributor Author

/assign @tao12345666333 @rikatz @strongjz
@tao12345666333 , this will build controller and other images, using the new base nginx image that has LD_LIBRARY_PATH for opentelemetry
Please review

@longwuyuan
Copy link
Contributor Author

The LD_LIBRARY_PATH is short of one directory name so cancel this and build base image all over again. Or better to add LD_LIBRARY_PATH to the controller image instead of the nginx base image

@longwuyuan longwuyuan closed this May 25, 2022
@longwuyuan longwuyuan deleted the opentelemetry branch June 24, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update nginx base image containing custom LD_LIBRARY_PATH
5 participants