move creation of dev devices in /chroot/dev from build image to run image

[rba]

What this PR does / why we need it:

While using the chroot ingress described in https://kubernetes.io/blog/2022/04/28/ingress-nginx-1-2-0/ we've got the following errors:

2022/05/09 07:08:43 [warn] [lua] lua_ingress.lua:32: get_seed_from_urandom(): failed
2022/05/09 07:08:43 [warn] [lua] lua_ingress.lua:59: randomseed(): failed
2022/05/09 12:24:44 [warn] [lua] lua_ingress.lua:32: get_seed_from_urandom(): failed
2022/05/09 12:24:44 [warn] [lua] lua_ingress.lua:59: randomseed(): failed

Inspecting /chroot/dev/urandom shows that it's a file instead of a character device:

$ docker run --rm  gcr.io/k8s-staging-ingress-nginx/controller-chroot:v1.2.0 ls -al /chroot/dev
total 12
drwxr-xr-x    2 root     root          4096 Apr 20 18:42 .
drwxr-xr-x    1 root     root          4096 Apr 20 18:43 ..
-rw-rw-rw-    1 root     root             0 Apr 20 18:42 full
-rw-rw-rw-    1 root     root             0 Apr 20 18:42 null
-rw-rw-rw-    1 root     root             0 Apr 20 18:42 ptmx
-rw-rw-rw-    1 root     root             0 Apr 20 18:42 random
-rw-rw-rw-    1 root     root             0 Apr 20 18:42 tty
-rw-rw-rw-    1 root     root             0 Apr 20 18:42 urandom
-rw-rw-rw-    1 root     root             0 Apr 20 18:42 zero

It seems that the docker COPY from the build to the run image is not able to copy the character special files correctly:

$ docker run --rm -it -v /var/run/docker.sock:/var/run/docker.sock wagoodman/dive:latest gcr.io/k8s-staging-ingress-nginx/controller-chroot:v1.2.0

After the change the image looks as follows:

$ docker run --rm  rbaumer/controller-chroot:1.0.0-dev ls -al /chroot/dev
total 8
drwxr-xr-x    1 root     root          4096 May 23 11:57 .
drwxr-xr-x    1 root     root          4096 May 23 11:57 ..
crw-rw-rw-    1 root     root        1,   7 May 23 11:57 full
crw-rw-rw-    1 root     root        1,   3 May 23 11:57 null
crw-rw-rw-    1 root     root        5,   2 May 23 11:57 ptmx
crw-rw-rw-    1 root     root        1,   8 May 23 11:57 random
crw-rw-rw-    1 root     root        5,   0 May 23 11:57 tty
crw-rw-rw-    1 root     root        1,   9 May 23 11:57 urandom
crw-rw-rw-    1 root     root        1,   5 May 23 11:57 zero

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

n/a

How Has This Been Tested?

Some basic testing has been done based on getting-started.md and this seems to be fine.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rba / name: Roman Baumer (0f22e28, 550eada)

[k8s-ci-robot]

@rba: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @rba!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rba. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rikatz]

/ok-to-test
/lgtm
/approve
Good catch!!
/hold

[rikatz]

/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rba, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment