Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match ServicePort to Endpoints by Name #846

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

justinsb
Copy link
Member

We can never match on the EndpointPort.Port; that is the container port.

We can never match on the EndpointPort.Port; that is the container port.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 46.55% when pulling cacc7bc on justinsb:serviceport into cdbf2aa on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jun 13, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2017
@aledbf
Copy link
Member

aledbf commented Jun 13, 2017

@justinsb thanks!

@aledbf aledbf merged commit e258ee1 into kubernetes:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants