-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute permissions to nginx image entrypoint.sh #8403
Add execute permissions to nginx image entrypoint.sh #8403
Conversation
@theunrealgeek: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @theunrealgeek. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage-accepted
/lgtm
/approve
Thanks,
; Long
…On Thu, 31 Mar, 2022, 10:05 AM Kubernetes Prow Robot, < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *theunrealgeek
<#8403#>*
To complete the pull request process
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>,
please assign *elvinefendi* after the PR has been reviewed.
You can assign the PR to them by writing /assign @ElvinEfendi in a
comment when ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=kubernetes%2Fingress-nginx>.
Needs approval from an approver in each of these files:
- *images/OWNERS
<https://github.com/kubernetes/ingress-nginx/blob/main/images/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
Reply to this email directly, view it on GitHub
<#8403 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWR5L3VI5A3KX37M46LVCUTRHANCNFSM5SEDCHRQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
/ok-to-test
Thanks,
; Long
…On Thu, 31 Mar, 2022, 10:10 AM Yuan, ***@***.***> wrote:
/triage-accepted
/lgtm
/approve
Thanks,
; Long
On Thu, 31 Mar, 2022, 10:05 AM Kubernetes Prow Robot, <
***@***.***> wrote:
> [APPROVALNOTIFIER] This PR is *NOT APPROVED*
>
> This pull-request has been approved by: *theunrealgeek
> <#8403#>*
> To complete the pull request process
> <https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>,
> please assign *elvinefendi* after the PR has been reviewed.
> You can assign the PR to them by writing /assign @ElvinEfendi in a
> comment when ready.
>
> The full list of commands accepted by this bot can be found here
> <https://go.k8s.io/bot-commands?repo=kubernetes%2Fingress-nginx>.
> Needs approval from an approver in each of these files:
>
> - *images/OWNERS
> <https://github.com/kubernetes/ingress-nginx/blob/main/images/OWNERS>*
>
> Approvers can indicate their approval by writing /approve in a comment
> Approvers can cancel approval by writing /approve cancel in a comment
>
> —
> Reply to this email directly, view it on GitHub
> <#8403 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABGZVWR5L3VI5A3KX37M46LVCUTRHANCNFSM5SEDCHRQ>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
/assign @ElvinEfendi
Thanks,
; Long
…On Thu, 31 Mar, 2022, 10:12 AM Kubernetes Prow Robot, < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *longwuyuan
<#8403 (comment)>*,
*theunrealgeek <#8403#>*
To complete the pull request process
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>,
please assign *elvinefendi* after the PR has been reviewed.
You can assign the PR to them by writing /assign @ElvinEfendi in a
comment when ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=kubernetes%2Fingress-nginx>.
Needs approval from an approver in each of these files:
- *images/OWNERS
<https://github.com/kubernetes/ingress-nginx/blob/main/images/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
Reply to this email directly, view it on GitHub
<#8403 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWUWHM4KZOWZB5PFYHDVCUUJRANCNFSM5SEDCHRQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
try this command 😆 /approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, rikatz, tao12345666333, theunrealgeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Try to fix the build that is broken in #8398
More discussion in https://kubernetes.slack.com/archives/C021E147ZA4/p1648563436309359
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: