-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove GIT_TAG from cloud build yaml #8394
Conversation
Signed-off-by: James Strong <[email protected]>
@strongjz: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve
/remove-hold
Thanks,
; Long
…On Mon, 28 Mar, 2022, 8:08 PM Yuan, ***@***.***> wrote:
/lgtm
Thanks,
; Long
On Mon, 28 Mar, 2022, 7:08 PM James Strong, ***@***.***>
wrote:
> @strongjz <https://github.com/strongjz> requested your review on: #8394
> <#8394> remove GIT_TAG
> from cloud build yaml.
>
> —
> Reply to this email directly, view it on GitHub
> <#8394 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABGZVWWQDN6OAEOR2GP3S7DVCGY6DANCNFSM5R3FZICA>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
|
/lgtm
Thanks,
; Long
…On Mon, 28 Mar, 2022, 8:15 PM Yuan, ***@***.***> wrote:
/approve
/remove-hold
Thanks,
; Long
On Mon, 28 Mar, 2022, 8:08 PM Yuan, ***@***.***> wrote:
> /lgtm
>
> Thanks,
> ; Long
>
> On Mon, 28 Mar, 2022, 7:08 PM James Strong, ***@***.***>
> wrote:
>
>> @strongjz <https://github.com/strongjz> requested your review on: #8394
>> <#8394> remove GIT_TAG
>> from cloud build yaml.
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#8394 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ABGZVWWQDN6OAEOR2GP3S7DVCGY6DANCNFSM5R3FZICA>
>> .
>> You are receiving this because your review was requested.Message ID:
>> ***@***.***>
>>
>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm
Thanks,
; Long
…On Mon, 28 Mar, 2022, 7:08 PM James Strong, ***@***.***> wrote:
@strongjz <https://github.com/strongjz> requested your review on: #8394
<#8394> remove GIT_TAG
from cloud build yaml.
—
Reply to this email directly, view it on GitHub
<#8394 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWWQDN6OAEOR2GP3S7DVCGY6DANCNFSM5R3FZICA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Signed-off-by: James Strong <[email protected]>
Signed-off-by: James Strong [email protected]
Last Nginx build used controller tag, removing that from the cloudbuild yaml
gcr.io/k8s-staging-ingress-nginx/nginx:v20220325-controller-v1.1.2-26-g529844886@sha256:7ccc42a11f321c975ccfb3d446581665602796d652f49795e1fb91fe445f2de3