Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GIT_TAG from cloud build yaml #8394

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

strongjz
Copy link
Member

Signed-off-by: James Strong [email protected]

Last Nginx build used controller tag, removing that from the cloudbuild yaml

gcr.io/k8s-staging-ingress-nginx/nginx:v20220325-controller-v1.1.2-26-g529844886@sha256:7ccc42a11f321c975ccfb3d446581665602796d652f49795e1fb91fe445f2de3

Signed-off-by: James Strong <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2022
@k8s-ci-robot
Copy link
Contributor

@strongjz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2022
@k8s-ci-robot k8s-ci-robot requested review from bowei and rikatz March 28, 2022 13:37
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@strongjz strongjz requested review from longwuyuan and tao12345666333 and removed request for bowei March 28, 2022 13:38
@longwuyuan
Copy link
Contributor

longwuyuan commented Mar 28, 2022 via email

@longwuyuan
Copy link
Contributor

longwuyuan commented Mar 28, 2022 via email

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9960efe into kubernetes:main Mar 28, 2022
@strongjz strongjz deleted the fix-nginx-tag branch March 28, 2022 16:57
@longwuyuan longwuyuan mentioned this pull request Mar 31, 2022
9 tasks
@longwuyuan
Copy link
Contributor

longwuyuan commented Oct 11, 2022 via email

rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
Signed-off-by: James Strong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants