Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade to 3.14.4 and fix tag #8386

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

strongjz
Copy link
Member

Signed-off-by: James Strong [email protected]

3.15.0 is causing unknown e2e test failures, 3.14.4 is working on e2e and fixes the CVE issues we have right now so using that going forward.

Also fixed the tag 1.1.2, 1.1.3 was updated too soon in the release process.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

@strongjz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@strongjz strongjz mentioned this pull request Mar 23, 2022
9 tasks
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start the release process after we've solved the CI related issues

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: strongjz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@longwuyuan
Copy link
Contributor

longwuyuan commented Mar 24, 2022 via email

@strongjz
Copy link
Member Author

There's a couple of different issues here.

OT was failing for reasons mentioned in the @longwuyuan PR and the issues mentioned in OT-cpp issue.
Nginx base was failing the e2e which to my knowledge has no bearing on OT.
I changed the tag back to 1.1.2 since I foobared it and added 1.1.3 too soon.

CI and e2e works with Nginx base image being on Alpine 3.14.4 as you can see with all the passing checks on this PR.

-James

@longwuyuan
Copy link
Contributor

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5298448 into kubernetes:main Mar 25, 2022
@dmathieu dmathieu mentioned this pull request Mar 29, 2022
9 tasks
@longwuyuan longwuyuan mentioned this pull request Mar 31, 2022
9 tasks
@strongjz strongjz deleted the alpine-3.14.4 branch April 2, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants