Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Alpine image in Dockerfile #8350

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

anaclaudiar
Copy link
Contributor

Upgrading Alpine base image, I think it got missed on this PR

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

@anaclaudiar: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @anaclaudiar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2022
@strongjz
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anaclaudiar, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3f19fd6 into kubernetes:main Mar 18, 2022
@strongjz
Copy link
Member

looks like there is a build issue with OT and alpine 3.15

#12 [linux/arm64 builder 3/3] RUN apk update 	&& apk upgrade 	&& apk add -U bash 	&& /build.sh
#12 CANCELED
------
 > [linux/amd64 builder 3/3] RUN apk update 	&& apk upgrade 	&& apk add -U bash 	&& /build.sh:
#18 63.39 
#18 63.40 -- Configuring done
#18 63.41 CMake Error at exporters/otlp/CMakeLists.txt:17 (add_library):
#18 63.41   Target "opentelemetry_exporter_otlp_grpc" links to target "re2::re2" but
#18 63.41   the target was not found.  Perhaps a find_package() call is missing for an
#18 63.41   IMPORTED target, or an ALIAS target is missing?
#18 63.41 
#18 63.41 
#18 63.46 -- Generating done
#18 63.46 CMake Generate step failed.  Build files cannot be regenerated correctly.

@strongjz
Copy link
Member

@anaclaudiar
Copy link
Contributor Author

anaclaudiar commented Mar 21, 2022

can you open an issue and investigate the build here is the full log.

@strongjz I can't see the logs, it seems they expired on Friday. I can open an issue but I can also revert this PR, if it is causing problems.

anaclaudiar added a commit to anaclaudiar/ingress-nginx that referenced this pull request Mar 22, 2022
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants