-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): add path and method labels to requests counter #8201
feat(metrics): add path and method labels to requests counter #8201
Conversation
Hi @naseemkullah. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2b5d7ac
to
cd95c41
Compare
@@ -190,7 +190,7 @@ func NewSocketCollector(pod, namespace, class string, metricsPerHost bool, bucke | |||
Namespace: PrometheusNamespace, | |||
ConstLabels: constLabels, | |||
}, | |||
[]string{"ingress", "namespace", "status", "service", "canary"}, | |||
requestTags, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I can't believe we had method
and path
for histograms all along if the concern was cardinality. Histograms are much more sensitive to cardinality since they have multiple metrics * buckets.
It makes sense to add method
and path
to nginx_ingress_controller_requests
, since these are valuable and each have finite cardinality. LGTM.
/assign @ElvinEfendi |
/assign @tao12345666333 |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind feature
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamNoah1, naseemkullah, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
closes #8200
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist:
Metrics are not yet documented: