Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Go install for misspell #8191

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Using Go install for misspell #8191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7929645
chore: using go install misspell
tao12345666333 Jan 26, 2022
b92e8cd
chore: fix typo
tao12345666333 Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ live-docs: ## Build and launch a local copy of the documentation website in http

.PHONY: misspell
misspell: ## Check for spelling errors.
@go get github.com/client9/misspell/cmd/misspell
@go install github.com/client9/misspell/cmd/misspell@latest
misspell \
-locale US \
-error \
Expand Down
2 changes: 1 addition & 1 deletion docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ FIELDS:

```

## What has caused this change in behaviour ?
## What has caused this change in behavior?

There are 2 reasons primarily.

Expand Down
4 changes: 2 additions & 2 deletions docs/user-guide/nginx-configuration/annotations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ Client Certificate Authentication is applied per host and it is not possible to

To enable, add the annotation `nginx.ingress.kubernetes.io/auth-tls-secret: namespace/secretName`. This secret must have a file named `ca.crt` containing the full Certificate Authority chain `ca.crt` that is enabled to authenticate against this Ingress.

You can further customize client certificate authentication and behaviour with these annotations:
You can further customize client certificate authentication and behavior with these annotations:

* `nginx.ingress.kubernetes.io/auth-tls-verify-depth`: The validation depth between the provided client certificate and the Certification Authority chain. (default: 1)
* `nginx.ingress.kubernetes.io/auth-tls-verify-client`: Enables verification of client certificates. Possible values are:
Expand Down Expand Up @@ -944,4 +944,4 @@ metadata:
listen 8000;
proxy_pass 127.0.0.1:80;
}
```
```
2 changes: 1 addition & 1 deletion test/e2e/settings/namespace_selector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ var _ = framework.IngressNginxDescribe("[Flag] watch namespace selector", func()
_, err = f.KubeClientSet.CoreV1().Namespaces().Update(context.TODO(), ns, metav1.UpdateOptions{})
assert.Nil(ginkgo.GinkgoT(), err, "labeling not matched namespace")

// update ingress to trigger reconcilation
// update ingress to trigger reconciliation
ing, err := f.KubeClientSet.NetworkingV1().Ingresses(notMatchedNs).Get(context.TODO(), notMatchedHost, metav1.GetOptions{})
assert.Nil(ginkgo.GinkgoT(), err, "retrieve test ingress")
if ing.Labels == nil {
Expand Down