Adding annotations to the controller service account

[bwlkr]

What this PR does / why we need it:

Adds the ability to annotate the controller service account. This is particularly useful when using IRSA on AWS.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

Ability to annotate the controller service account, this could be viewed as new functionality but as its such a small change and was part of the deprecated nginx helm chart I've put it as a fix.

How Has This Been Tested?

Tested changes with updated values file, everything deployed successfully with the service account annotations being provisioned correctly.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Billy Walker (8799813)

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @bwlkr!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bwlkr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bwlkr]

/assign @ChiefAlexander

[longwuyuan]

@bwlkr Thank you for your contribution. It helps.

This seems like ready to merge except that there is no info on the history, context and safety of the change. My suggestion would be ;

• Create a issue and document the current problem this solves with context
• Copy/paste screenshots along with commands & ouputs that show a working example of the change & with a working annotation.

Once above 2 aspects are taken care of, then this is good to merge I feel.
At the same time, we also wait to see if there are other comments/suggestions coming in.

[iamNoah1]

/kind bug
/triage accepted
/priority important-soon

[bwlkr]

Thanks @longwuyuan, as requested I've raised an issue to add context.

Below are screenshots of values used:

And the generated helm template for the controller service account:

Once applied I can exec onto a controller pod and see the correct env variables populated from the above eks annotation.

$ env | grep aws
AWS_ROLE_ARN=arn:aws:iam:::role/eks-nginx-ingress
AWS_WEB_IDENTITY_TOKEN_FILE=/var/run/secrets/eks.amazonaws.com/serviceaccount/token

[longwuyuan]

/ok-to-test

Thanks for the contribution. It helps
/lgtm

[longwuyuan]

/kind feature
/remove-kind bug

[rikatz]

/approve
Thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bwlkr, longwuyuan, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment