-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the $req_id placeholder description #8163
Conversation
@alexbrand , thanks for your contribution. This PR is good to be merged but we can hopefully make some improvements. Can you please create a issue and link it here. In the issue, kindly describe the context and background, so new users looking to understand this change can get the info needed. Hopefully you can provide some explanation and some URLs. /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind documentation
/triage accepted
/priority important-soon
@longwuyuan to be honest I don't think we need an Issue in order to get this small change merged.
/lgtm
/hold for @longwuyuan
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexbrand, iamNoah1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Updates the documentation for the
$req_id
placeholder, as it currently does not mention that the value of$req_id
is taken from theX-Request-Id
header if available, per https://github.com/kubernetes/ingress-nginx/blob/main/rootfs/etc/nginx/template/nginx.tmpl#L396:L403What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: