-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix api version, in basic usage docs, for example ingress objects, for K8s version <1.19 #8112
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@tacf: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @tacf! |
Hi @tacf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The main branch will reflect support for latest release of K8S so thi PR is invalid. If you have opinions/thoughts that are not expressed here,, Please create a issue and detail why the main documentation should spec deprecated apiVersion. THen link it here. If it makes sense then this PR can be re-opened. /close |
@longwuyuan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reopening PR as requested by @longwuyuan /reopen |
@tacf: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tacf, thanks again for the PR. |
hi @tacf in case you have not noticed, you need to change other fields in the example. |
While you review is pending i'll not be able to see it. You need to publish it first. Changed the text based on your suggestion with minor wording differences. |
I am still unsure where I messed up but i was able to cancel that pending thing, as the file has changed already, based on your latest commit. We can move ahead for now. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, tacf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind documentation |
/retest |
Hi @tacf , your PR has merged but I don't see the docs website content change at https://kubernetes.github.io/ingress-nginx/user-guide/basic-usage/ . Can you confirm that you too, don't see the content changed ? |
Hi, can't see it yet. It seems that there was no new release after the changes so i'm guessing that's the reason why. |
As a note, this resolves #8122 |
I am waiting to find out why the docs website does not reflect the change. So I can make the website look good as well. |
Seems to be a deeper problem with the actions configured or some previous issue. Actions for documentation publishing are failing for a while now. Do you have any ideia who to escalate this to? |
Escalated already.
Lets wait for updates. Glad we know more now.
Thanks,
; Long Wu Yuan
…On 1/13/22 7:21 PM, Tiago Ferreira wrote:
Seems to be a deeper problem with the actions configured or some
previous issue. Actions for documentation publishing are failing for a
while now. Do you have any ideia who to escalate this to?
—
Reply to this email directly, view it on GitHub
<#8112 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWVAIRWUS2MAKTNV6YLUV3KG5ANCNFSM5LO5NDUQ>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
@tacf, i see that a documentation job and a helm job passed in the gh-actions pipeline. Can you submit one more PR with the exact same content and just add/remove a space or a dot/period character so that there is at least a one char diff. I will approve it so it can fire another CI run and hopefully make progress on updating tthat doc website page. |
Did you check if the job executed the update phase? There are many docs workflows that pass but those are mainly the one that do not go into de update stage. I've checked a few and they all fail when executing the update stage |
That is correct. The "apparent" pass is because of update steps not
running and we are suspecting expired token.
Only way to know more is run the job so I asked for another PR.
Thanks,
; Long Wu Yuan
…On 1/14/22 3:05 PM, Tiago Ferreira wrote:
Did you check if the job executed the update phase? There are many
docs workflows that pass but those are mainly the one that do not go
into de update stage. I've checked a few and they all fail when
executing the update stage
—
Reply to this email directly, view it on GitHub
<#8112 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWRQCZDIAGT4SVXFBZDUV7U7VANCNFSM5LO5NDUQ>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
@longwuyuan sorry i missed this last message of yours. The same content on another PR will probably not work because the update only runs on master and with content changes on docs. So actually we need another "real" change, or if possible to re-run some previous workflow. |
We fixed the token and website is updated after a cosmetic-change PR.
Can you check and confirm ?
Thanks,
; Long Wu Yuan
…On 1/17/22 7:24 PM, Tiago Ferreira wrote:
@longwuyuan <https://github.com/longwuyuan> sorry i missed this last
message of yours. The same content on another PR will probably not
work because the update only runs on master and with content changes
on docs. So actually we need another "real" change, or if possible to
re-run some previous workflow.
—
Reply to this email directly, view it on GitHub
<#8112 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWSW3MVQYAEW2VC7KA3UWQNQ5ANCNFSM5LO5NDUQ>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@longwuyuan yes, change is there. Tyvm for all the help |
Thank you very much for your contribution. Helps a lot. |
Oficial documentation sources:
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: