-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove force sync for non-external backends #7958
Conversation
@ZxYuan: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ZxYuan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @tao12345666333 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, ZxYuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In PR #5726 and #5418, dynamic LB sync was applied to prevent syncing per second for non-external backends. However, a strategy of force syncing non-external backends per 30s was also added. Practically, the additional strategy is unnecessary but leads to waste of CPUs when number of ingresses/services is large.
What this PR does / why we need it:
This PR remove force sync for non-external backends.
The figures below show how much impact current LB has on CPU usage (%) with/without FORCE sync (No input traffic into nginx). Without FORCE sync, CPU usage per nginx worker keeps <1%.
CPU model name: Intel(R) Xeon(R) Silver 4208 CPU @ 2.10GHz
1000 services&ingresses with FORCE sync
2000 services&ingresses with FORCE sync
3000 services&ingresses with FORCE sync
4000 services&ingresses with FORCE sync
5000 services&ingresses with FORCE sync
6000 services&ingresses with FORCE sync
7000 services&ingresses with FORCE sync
8000 services&ingresses with FORCE sync
8000 services&ingresses without FORCE sync
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Create a nginx deployment on port 80 with label
app: nginx
.Save the following yaml as
press.yaml.tmpl
.Run the bash script
Checklist: