-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applied allowPrivilegeEscalation=false #7948
applied allowPrivilegeEscalation=false #7948
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@swgriffith: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @swgriffith! |
Hi @swgriffith. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7399be4
to
b9eafca
Compare
|
/lgtm Thanks for putting this in. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: strongjz, swgriffith The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.1.0 |
This PR addresses issue #7947 by adding the allowPrivilegeEscalation=false flag in the CreateSecret and PathWebHook job specs.
What this PR does / why we need it:
See issue #7947 for the full details, but in short Azure Policy blocks installation of nginx-ingress in some cases. We may be able to get this resolved in Azure Policy, but this may also be a reasonable change in nginx-ingress directly.
Types of changes
Which issue/s this PR fixes
Fixes Issue #7947
How Has This Been Tested?
I've run through all of the steps to recreate from the issue and confirmed that it address the issue and ingress runs successfully.
Checklist: