Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OpenTelemetry to nginx base image #7669

Merged
merged 1 commit into from
Oct 11, 2021
Merged

add OpenTelemetry to nginx base image #7669

merged 1 commit into from
Oct 11, 2021

Conversation

dmathieu
Copy link
Contributor

I'm splitting this from #7621 so the image can be built and releases independently from the rest of the code changes.

This adds OpenTelemetry CPP and the nginx module to the docker image so it can be used by the controller later.

S390x is skipped, because the GRPC package has been removed from the alpine image, so we can't install the required dependencies.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

@dmathieu: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @dmathieu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2021
@rikatz rikatz added this to the v1.1.0 milestone Sep 26, 2021
@rikatz
Copy link
Contributor

rikatz commented Sep 26, 2021

/assign

@rikatz
Copy link
Contributor

rikatz commented Sep 26, 2021

So, if someone is using s390x, Opentelemetry wont be available right?

What is the alternative in this case, assuming we want to remove the other telemetry things in a future and use only OTEL?

@rikatz
Copy link
Contributor

rikatz commented Sep 26, 2021

Oh, another thing I've been thinking is about splitting the extra bigger modules from the main nginx build image, and let me explain:

Today we take a HUGE amount of time to rebuild nginx base images, even if we are just patching something in openresty. This is mostly due to opentelemetry/opentracing/modsecurity builds.

As all of those are dynamic nginx modules, I think it would be cool if we could just build those images as separate process (download the same nginx source, and build just a container with those modules) and then, during deployment users willing to enable those modules should add those as sidecars.

I did some experiments in #7593 but this need some simplifying.

Will think about that for future modules.

@dmathieu
Copy link
Contributor Author

Unfortunately, until S390X has support for GRPC in alpine, I'm afraid there isn't much we'll be able to do, outside maybe of using Ubuntu for that platform.

I definitely get the need for a speedier build system, especially since not every module needs to be built every time.

@rikatz
Copy link
Contributor

rikatz commented Oct 11, 2021

/lgtm
/approve
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmathieu, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0c16980 into kubernetes:main Oct 11, 2021
@dmathieu dmathieu deleted the otel-base-image branch October 11, 2021 13:23
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants