-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add OpenTelemetry to nginx base image #7669
Conversation
@dmathieu: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @dmathieu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
So, if someone is using s390x, Opentelemetry wont be available right? What is the alternative in this case, assuming we want to remove the other telemetry things in a future and use only OTEL? |
Oh, another thing I've been thinking is about splitting the extra bigger modules from the main nginx build image, and let me explain: Today we take a HUGE amount of time to rebuild nginx base images, even if we are just patching something in openresty. This is mostly due to opentelemetry/opentracing/modsecurity builds. As all of those are dynamic nginx modules, I think it would be cool if we could just build those images as separate process (download the same nginx source, and build just a container with those modules) and then, during deployment users willing to enable those modules should add those as sidecars. I did some experiments in #7593 but this need some simplifying. Will think about that for future modules. |
Unfortunately, until S390X has support for GRPC in alpine, I'm afraid there isn't much we'll be able to do, outside maybe of using Ubuntu for that platform. I definitely get the need for a speedier build system, especially since not every module needs to be built every time. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmathieu, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm splitting this from #7621 so the image can be built and releases independently from the rest of the code changes.
This adds OpenTelemetry CPP and the nginx module to the docker image so it can be used by the controller later.
S390x is skipped, because the GRPC package has been removed from the alpine image, so we can't install the required dependencies.