-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http request test to annotation ssl cipher e2e test #7431
Conversation
Signed-off-by: Bhumij Gupta <[email protected]>
Welcome @bhumijgupta! |
Hi @bhumijgupta. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
nit: In the description of the PR, the word used is "nginx" and I would use ingress-nginx-controller or ingress-nginx or just controller. :-) |
/triage accepted |
Edited the description |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bhumijgupta, rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Bhumij Gupta <[email protected]>
Signed-off-by: Bhumij Gupta [email protected]
What this PR does / why we need it:
This PR adds backend test to ensure that ingresss-nginx works with the given annotation for
annotation/sslcipher
e2e testsTypes of changes
Which issue/s this PR fixes
Part of #7407
How Has This Been Tested?
The tests are passing with
make kind-e2e-test
Checklist: