-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus & grafana - fix for usage docs #7361
Conversation
Hi @longwuyuan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
docs/user-guide/monitoring.md
Outdated
controller: | ||
metrics: | ||
enabled: true | ||
service: | ||
annotations: | ||
prometheus.io/port: "10254" | ||
prometheus.io/scrape: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this aligned?
Maybe
controller: | |
metrics: | |
enabled: true | |
service: | |
annotations: | |
prometheus.io/port: "10254" | |
prometheus.io/scrape: "true" | |
controller: | |
metrics: | |
enabled: true | |
service: | |
annotations: | |
prometheus.io/port: "10254" | |
prometheus.io/scrape: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indented as suggested
@longwuyuan this documentation is really good! Overall LGTM, just that really small nit about yaml alignment /approve Thanks! |
Its copied from that link blog but it needs to be changed to servicemonitor approach.
Not an expert ... :-) google helping me search and one user shared that link.
Indenting fixed, looking for LGTMThanks,
--
; Long
16 Jul 2021, 17:50 by ***@***.***:
…
@longwuyuan <https://github.com/longwuyuan>> this documentation is really good!
Overall LGTM, just that really small nit about yaml alignment
/approve
Once you fix this, we can lgtm
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, > view it on GitHub <#7361 (comment)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWUVSCVBD3S7B533GXDTYAPZDANCNFSM5APIJPHQ>> .
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The documentation for prometheus & grafana installation is not describing how to enable metrics. The kustomization files for prometheus and grafana have hardcoded outdated versions. This PR inserts the instructions to enable metrics and also removes the tag for image from kustomization yaml file, so that latest prometheus and grafana gets installed. There is also instructions added to import the dashboard which was too short before.
Types of changes
Which issue/s this PR fixes
fixes #7197
fixes #7285
How Has This Been Tested?
Checklist: