-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc - replaced fortune-builder app with official greeter app #7360
Conversation
Hi @longwuyuan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @strongjz |
/lgtm Thanks for updating that! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
In the example config for the "backend-protocol: GRPC" annotation, there is a gRPC app referenced . The app is called "fortune-builder". It is outdated and uses bazel to build. But the build does not work, as documented and its not worth fixing it. The issue Building FortuneBuilder app #7301 has details on the problem and the discussion done so far. This PR replaces the fortunebuilder app with a app called "greeter". Greeter is published from the official gRPC github repo https://github.com/grpc/grpc-go/blob/master/examples/features/reflection/server/main.go (and greeter app is also referenced in the gRPC website quickstart).
#7301
#7316
Some very useful info here https://gist.github.com/aledbf/b9eaa19b36b1127ef812bd7ff319f141
Types of changes
Which issue/s this PR fixes
fixes #7301
fixes #7316
-->
How Has This Been Tested?
Checklist: