Fix nilpointer in admission and remove failing test #7255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
…ckend ingress Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
rikatz
force-pushed
the
fix-nilpointer-admission
branch
from
d46b7ce to
9aff9ba
Compare
|
/assign I will follow up on this PR today or tomorrow. |
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
k8s-ci-robot
added
size/S
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
rikatz
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Pchevuzinske Katz [email protected]
What this PR does / why we need it:
Admission webhook is used to validate conflicts between ingresses, but it fails to validate when a user tries to add a new ingress with no host and path /, as there's already in its structs a reference with Default Backend, that does not contain any ingress object inside location.Ingress (nil)
Types of changes
Which issue/s this PR fixes
Fixes #7198
How Has This Been Tested?
Created the controller, deployed multiple ingress specs.
Validated that: