-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set x-forwarded-scheme to be the same as x-forwarded-proto #7126
set x-forwarded-scheme to be the same as x-forwarded-proto #7126
Conversation
Hi @timmysilv. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think x-forwarded-scheme
is rarely used, but it does exist.
/lgtm
Just for note: Note that Heroku, AWS and Google Cloud Platform all use X-Forwarded-Proto (and not -Scheme) in their HTTP load balancing service. |
2bec074
to
9b00a49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, tao12345666333, timmysilv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR does NOT make/change any routing decisions based on the X-Forwarded-Scheme header. However, for consistency, any changes made in lua to the X-Forwarded-Proto header should also be applied to the X-Forwarded-Scheme header in case some upstream uses it. An example would be the Ruby Rack library.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
I updated the e2e test to ensure the header is overwritten based on the config option that is set.
Checklist: