-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tests for store/endpoint #7039
Add missing tests for store/endpoint #7039
Conversation
Hi @shuheiktgw. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -0,0 +1,66 @@ | |||
/* | |||
Copyright 2017 The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's probably 2021.
Will review the tests later, will release the CI to make its part :)
/ok-to-test |
/retest |
@shuheiktgw can you please fix also the file header? Thanks |
/lgtm Thank you! Tests are always welcome! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, shuheiktgw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
also, I'll leave the header as 2017, but we should change this in a future to the current commit ;) |
What this PR does / why we need it:
I noticed some tests are missing so I added them. Thank you for your review!
Types of changes
Which issue/s this PR fixes
None
How Has This Been Tested?
None
Checklist: