Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup chart code #5204

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Cleanup chart code #5204

merged 1 commit into from
Mar 3, 2020

Conversation

ChiefAlexander
Copy link
Contributor

What this PR does / why we need it:

Cleaning up the charts code

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

Relates to #5161

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ChiefAlexander. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot requested review from aledbf and cmluciano March 3, 2020 15:24
@aledbf
Copy link
Member

aledbf commented Mar 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2020
aledbf
aledbf reviewed Mar 3, 2020
View reviewed changes
charts/ingress-nginx/templates/_helpers.tpl
Return the appropriate apiVersion for daemonset.
*/}}
{{- define "daemonset.apiVersion" -}}
{{- if semverCompare ">=1.9-0" .Capabilities.KubeVersion.GitVersion -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't think is time to raise the minimum k8s version?
Not sure makes sense keep this compatibility for something is not supported in the main k/k repository. Just a thought.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for upping the supported k8s version for this chart. The purpose of this pr is just to standardize the chart to make it easier to read and fix some of the small inconsistencies.
Are we also going to define a minimum supported version of ingress-nginx?

Copy link
Member

@aledbf aledbf Mar 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we also going to define a minimum supported version of ingress-nginx?

I don't want to say yes, but in the last week, I've seen several issues to ingress-nginx 0.20.0 (almost 18 months old).
Can we limit the label so that it is not older than three versions? If the user decides to use helm template and using something older than that, fine, but it will required additional effort.
Makes sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for upping the supported k8s version for this chart.

What is the version now? (stable/nginx-ingress)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been updating the chart to the latest version of ingress-nginx when it is released. As apart of the repo I'd like to have something within the release handling that just magically updates it :)

kubeVersion: ">=1.10.0-0" This is defined in the chart.yaml

Copy link
Contributor Author

@ChiefAlexander ChiefAlexander Mar 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could provide a requirement that to run the chart it has to be at least three versions behind. Then if someone wants to run a version older they would have to use an older version of the chart. A version of ingress-nginx and or kubernetes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to do ^^ here or in a different PR?
(merging as-is :+1 to me)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer that in another pr. Let's add that to the issue for the chart.

@aledbf
Copy link
Member

aledbf commented Mar 3, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ChiefAlexander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8bfb317 into kubernetes:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@cmluciano cmluciano Awaiting requested review from cmluciano

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChiefAlexander @k8s-ci-robot @aledbf