-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Datadog sample rate with global trace sampling from configmap #4897
Support Datadog sample rate with global trace sampling from configmap #4897
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @dmxlsj. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e1bec67
to
be6a6c3
Compare
/ok-to-test |
@dmxlsj please squash the commits |
Codecov Report
@@ Coverage Diff @@
## master #4897 +/- ##
======================================
Coverage 58.5% 58.5%
======================================
Files 88 88
Lines 6719 6719
======================================
Hits 3931 3931
Misses 2359 2359
Partials 429 429
Continue to review full report at Codecov.
|
c01aceb
to
f9413f2
Compare
sorry messed up the rebase as I was originally working out of on 0.25 release. |
f9413f2
to
d7be5db
Compare
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feedback (dd-opentracing-cpp maintainer) is that it looks correct (code, docs and comments) and the graph from testing show it clearly working as intended.
@cgilmour thank you for the review! |
/lgtm |
@dmxlsj thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, dmxlsj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I have been looking for a way to do a Datadog trace sampling in a global level, and ended up filing a PR.
Currently dd-opentracing-cpp has a capability to disable priority sampling (client-side sampling) and use global sampling rate, however there is no native way for ingress-nginx to support this.
Please see the
Annotated Datadog config JSON
section.https://github.com/DataDog/dd-opentracing-cpp/blob/7d58654a41a4fa4589988d105f953049f9eeee3c/README.md#guide
In this PR, I added the following:
datadog-priority-sampling
anddatadog-sample-rate
in configmapthird-party-addons
I tested the change in my local development.
datadog-priority-sampling
in configmapdatadog-sample-rate
from configmap and observe the differenceWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):No known open issues that I know of
Special notes for your reviewer:
Probably useful to get some eyes of dd-opentracing-cpp maintainer, so cc-ing @cgilmour here as this issue was my starting point of this PR.