-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OCSP #4868
Add support for OCSP #4868
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4868 +/- ##
=======================================
Coverage 58.49% 58.49%
=======================================
Files 88 88
Lines 6719 6719
=======================================
Hits 3930 3930
Misses 2361 2361
Partials 428 428
Continue to review full report at Codecov.
|
98059d5
to
0c526e6
Compare
This PR is working, just need to finish pending items |
manual test: |
/hold |
/test all |
/retest |
@aledbf: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
TODO:
(without this we could get rate-limited and also introduces ~20s in the response time)
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #4758Special notes for your reviewer: