Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OCSP #4868

Closed
wants to merge 1 commit into from
Closed

Add support for OCSP #4868

wants to merge 1 commit into from

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 29, 2019

What this PR does / why we need it:

TODO:

  • skip ocsp for default backend with fake certificate
  • skip for self-signed certificates?
  • use a cache to avoid unnecessary requests
    (without this we could get rate-limited and also introduces ~20s in the response time)
  • lua test
  • e2e test
  • check if ocsp setting is enabled
  • check sni host is a valid hostname for the ingress controller
  • support for OCSP must staple extension?

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4758

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2019
@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #4868 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4868   +/-   ##
=======================================
  Coverage   58.49%   58.49%           
=======================================
  Files          88       88           
  Lines        6719     6719           
=======================================
  Hits         3930     3930           
  Misses       2361     2361           
  Partials      428      428
Impacted Files Coverage Δ
internal/ingress/controller/template/configmap.go 77.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0061f...088066c. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Dec 29, 2019

This PR is working, just need to finish pending items

@aledbf
Copy link
Member Author

aledbf commented Dec 29, 2019

manual test:
openssl s_client -connect HOSTNAME:443 -servername HOSTNAME -status < /dev/null

@aledbf
Copy link
Member Author

aledbf commented Dec 30, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2019
@aledbf
Copy link
Member Author

aledbf commented Jan 5, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 5, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 5, 2020

@aledbf: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-ingress-nginx-test-lua 088066c link /test pull-ingress-nginx-test-lua

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@leonklingele leonklingele mentioned this pull request Feb 8, 2020
@aledbf aledbf closed this Feb 21, 2020
@aledbf aledbf deleted the ocsp branch March 14, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nginx] Support OCSP Stapling
4 participants