Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define minimum limits to run the ingress controller #4843

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 17, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4735

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@aledbf
Copy link
Member Author

aledbf commented Dec 17, 2019

/retest

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@facf841). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4843   +/-   ##
=========================================
  Coverage          ?   58.46%           
=========================================
  Files             ?       88           
  Lines             ?     6719           
  Branches          ?        0           
=========================================
  Hits              ?     3928           
  Misses            ?     2362           
  Partials          ?      429

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update facf841...42ee1e4. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Dec 17, 2019

/retest

@aledbf aledbf merged commit d83b83b into kubernetes:master Dec 23, 2019
@aledbf aledbf deleted the limitrange branch December 24, 2019 11:46
@edmorley
Copy link

edmorley commented Mar 4, 2020

Hi! The LimitRange added here is causing errors with the default cert-manager Issuer configurations - see #5210. Many thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not obviously serious issue about CPU, nginx-ingress http://IP:10254/healthz fails constantly
4 participants