-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Modsecurity-nginx to latest (v1.0.1) #4842
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @theoretick! |
Hi @theoretick. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@theoretick please sign the CLA |
Updates Modsecurity-nginx connector to release v1.0.1
I have now signed the CLA |
/ok-to-test |
/lgtm |
@theoretick thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, theoretick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aledbf thanks! I didn't see any guidance in the docs, how frequently is a new release cut and/or when can we expect this change to be released? |
New releases are between two and three months or ASAP in case of security incidents. This change will be available tomorrow in the dev tag image (https://quay.io/repository/kubernetes-ingress-controller/nginx-ingress-controller?tab=tags) |
Codecov Report
@@ Coverage Diff @@
## master #4842 +/- ##
=========================================
Coverage ? 58.46%
=========================================
Files ? 88
Lines ? 6719
Branches ? 0
=========================================
Hits ? 3928
Misses ? 2362
Partials ? 429 Continue to review full report at Codecov.
|
@theoretick the dev tag is already available |
Updates Modsecurity-nginx connector to release v1.0.1
What this PR does / why we need it:
Updates
Modsecurity-nginx
connector to latest version,v1.0.1.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: