Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go dependencies to v1.17.0 #4823

Merged
merged 3 commits into from
Dec 12, 2019
Merged

Update go dependencies to v1.17.0 #4823

merged 3 commits into from
Dec 12, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 11, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@aledbf
75c3c47 
Update go dependencies to v1.17.0
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2019
@aledbf
Copy link
Member Author

aledbf commented Dec 11, 2019

/retest

@aledbf
fe2ae8a 
Check the configmap is valid
@aledbf
1d46ec2 
Cleanup test
@codecov-io
Copy link

codecov-io commented Dec 11, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@67dce30). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4823   +/-   ##
=========================================
  Coverage          ?   58.46%           
=========================================
  Files             ?       88           
  Lines             ?     6719           
  Branches          ?        0           
=========================================
  Hits              ?     3928           
  Misses            ?     2362           
  Partials          ?      429
Impacted Files Coverage Δ
internal/ingress/controller/store/store.go 58.26% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dce30...1d46ec2. Read the comment docs.

ElvinEfendi
ElvinEfendi reviewed Dec 12, 2019
View reviewed changes
internal/ingress/controller/store/store.go
@@ -891,6 +891,10 @@ func (s *k8sStore) setConfig(cmap *corev1.ConfigMap) {
s.backendConfigMu.Lock()
defer s.backendConfigMu.Unlock()

if cmap == nil {
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it we get an exception in the tests (this happens only after updating the dependencies)

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit be19071 into kubernetes:master Dec 12, 2019
@aledbf aledbf deleted the go-modules branch December 12, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvinEfendi ElvinEfendi ElvinEfendi left review comments

@bowei bowei Awaiting requested review from bowei

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @codecov-io @ElvinEfendi @k8s-ci-robot