-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jaeger to include debug-id tag bugfix #4802
Conversation
Recently one of my colleague fixed this issue in the cpp jaeger library https: //github.com/jaegertracing/jaeger-client-cpp/commit/741b1af2805388e98dbfea449f40c6d6b19c13be Signed-off-by: Gianluca Arbezzano <[email protected]>
Welcome @gianarb! |
Hi @gianarb. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gianarb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign aledbf I don't know if you remember @aledbf but we had a discussion on Slack about this https://kubernetes.slack.com/archives/CANQGM8BA/p1574938366128400 I hope this PR will help to figure out what is going on |
Closing. Please check #4803 |
What this PR does / why we need it:
Recently one of my colleagues fixed this issue in the cpp jaeger library
https: //github.com/jaegertracing/jaeger-client-cpp/commit/741b1af2805388e98dbfea449f40c6d6b19c13be