Update nginx image to use openresty master #4780
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, cmluciano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4780 +/- ##
=========================================
Coverage ? 58.54%
=========================================
Files ? 88
Lines ? 6702
Branches ? 0
=========================================
Hits ? 3924
Misses ? 2352
Partials ? 426Continue to review full report at Codecov.
|
| @@ -441,6 +442,10 @@ WITH_MODULES="--add-module=$BUILD_PATH/nginx-http-auth-digest-$NGINX_DIGEST_AUTH | |||
| --add-module=$BUILD_PATH/nginx_ajp_module-${NGINX_AJP_VERSION} \ | |||
| --add-module=$BUILD_PATH/ngx_brotli" | |||
|
|
|||
| make | |||
|
|
|||
| cd openresty-1.17.4.1rc0 | |||
There was a problem hiding this comment.
you could do cd "$BUILD_PATH/openresty-$OPENRESTY_VERSION", except you changed version to sha. Should we maybe introduce another variable for version?
| @@ -441,6 +442,10 @@ WITH_MODULES="--add-module=$BUILD_PATH/nginx-http-auth-digest-$NGINX_DIGEST_AUTH | |||
| --add-module=$BUILD_PATH/nginx_ajp_module-${NGINX_AJP_VERSION} \ | |||
| --add-module=$BUILD_PATH/ngx_brotli" | |||
|
|
|||
| make | |||
There was a problem hiding this comment.
Why do you need this make now?
There was a problem hiding this comment.
This is temporal. It will be removed after the next release of openresty
|
This probably broke https://github.com/kubernetes/ingress-nginx/pull/4780/files#diff-4a5113d28634e29f2ab0bca34da7a3e5R383. -- Also why are we using latest master and not waiting for stable release? |
Because it's being more than three months since the last release. Just in case I am not planning in releasing a new version without a stable release from openresty |
What this PR does / why we need it:
Updates openresty to 1.17.4 (current master) and nginx-opentracing modules
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: