-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add info about x-forwarded-prefix breaking change #4777
[docs] Add info about x-forwarded-prefix breaking change #4777
Conversation
Hi @Miouge1. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@Miouge1 thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4777 +/- ##
=========================================
Coverage ? 58.65%
=========================================
Files ? 88
Lines ? 6753
Branches ? 0
=========================================
Hits ? 3961
Misses ? 2355
Partials ? 437 Continue to review full report at Codecov.
|
What this PR does / why we need it:
#3786 changed the way the
x-forwarded-prefix
annotation worked. Informing users in release notes helps with to take appropriate action when upgrading.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
I am using the
x-forwarded-prefix: true
annotation and ran into problems when upgrading from v0.21 to v0.26.I am not sure about the appropriate mitigation, so far the following worked for me:
v0.21
v0.26