-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker image: Add source code reference label #4747
Docker image: Add source code reference label #4747
Conversation
This allows tools that automate component updates (in our case Renovate Bot [1]) to automatically find the source repository for the Docker image and extract release notes from there. Renovate Bot can include the relevant release notes automatically in a merge request changing the component version. In [2], Renovate added the label for their own Docker image. [1] https://github.com/renovatebot/renovate [2] renovatebot/renovate#3753
Hi @mfrister. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Will defer to @aledbf on this one |
@mfrister I don't see any issues adding this label but I think we should add more labels than "source", like
WDYT? |
@aledbf Good idea. Added the labels you suggested, using the |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4747 +/- ##
==========================================
+ Coverage 58.6% 58.62% +0.01%
==========================================
Files 88 88
Lines 6743 6743
==========================================
+ Hits 3952 3953 +1
+ Misses 2355 2353 -2
- Partials 436 437 +1
Continue to review full report at Codecov.
|
/lgtm |
@mfrister thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, mfrister The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add a opencontainers-standardized label (source) to the Docker image, referencing the ingress-nginx GitHub repository.
This allows tools that automate component updates (in our case Renovate Bot) to automatically find the source repository for the Docker image and extract release notes from there. Renovate Bot can include the relevant release notes automatically in a merge request changing the component version.
In renovatebot/renovate#3753, Renovate added the label for their own Docker image.