-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify initialization function of bytes.Buffer #4669
Conversation
Welcome @frioux! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @frioux. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
/assign @bowei
…--
Sent from a rotary phone rented from Ma Bell
On Sat, Oct 12, 2019, 8:39 AM Kubernetes Prow Robot < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *frioux
<#4669#>*
To complete the pull request process
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>,
please assign *bowei*
You can assign the PR to them by writing /assign @bowei in a comment when
ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=kubernetes%2Fingress-nginx>.
Needs approval from an approver in each of these files:
- *OWNERS
<https://github.com/kubernetes/ingress-nginx/blob/master/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4669?email_source=notifications&email_token=AAAB7Y2SI5YZ46UKXSLO3KDQOHVSFA5CNFSM4JADKGIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCCDFY#issuecomment-541335959>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAB7Y64UJJEXVYYI723WCTQOHVSFANCNFSM4JADKGIA>
.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, frioux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@frioux please don't assign PRs manually. Thanks |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4669 +/- ##
=========================================
+ Coverage 58.67% 58.7% +0.02%
=========================================
Files 88 88
Lines 6764 6763 -1
=========================================
+ Hits 3969 3970 +1
+ Misses 2356 2355 -1
+ Partials 439 438 -1
Continue to review full report at Codecov.
|
Sorry I thought the bot was saying to?
…--
Sent from a rotary phone rented from Ma Bell
On Sat, Oct 12, 2019, 9:20 AM Manuel Alejandro de Brito Fontes < ***@***.***> wrote:
/ok-to-test
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4669?email_source=notifications&email_token=AAAB7Y5TFDNGRXXQABKG3I3QOH2L7A5CNFSM4JADKGIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCC7ZY#issuecomment-541339623>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAB7YYKAHT7SFLNYZIHQRDQOH2L7ANCNFSM4JADKGIA>
.
|
/retest All seem to be timeouts? |
What this PR does / why we need it:
Simplifies some code; just better style and slightly faster.