Bind ingress controller to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes

[wawa0210]

What this PR does / why we need it:

Bind ingress controller to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes. The image doesn't support on windows

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

/clean-up

Special notes for your reviewer:

Bind ingress controller to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes

/assign @ElvinEfendi

[k8s-ci-robot]

Welcome @wawa0210!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @wawa0210. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aledbf]

Please use kubernetes.io/os

[aledbf]

@wawa0210 please don't assign PRs manually. Thanks

[aledbf]

/ok-to-test

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@69880ac). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #4645   +/-   ##
========================================
  Coverage          ?   58.7%           
========================================
  Files             ?      88           
  Lines             ?    6763           
  Branches          ?       0           
========================================
  Hits              ?    3970           
  Misses            ?    2355           
  Partials          ?     438

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69880ac...1908d0e. Read the comment docs.

[aledbf]

/retest

[wawa0210]

Please use kubernetes.io/os

FIxed .

[wawa0210]

@wawa0210 please don't assign PRs manually. Thanks

I am very sorry, I will pay attention next time.

[aledbf]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

@wawa0210 thanks!

[wawa0210]

@petersalomonsen Since the release of kubernetes 1.14, this label kubernetes.io/os has been declared to be officially usable. At the same time, the previous label beta.kubernetes.io/os was declared deprecated.

https://github.com/kubernetes/website/commit/851ef58fa8413e47bb18a15de53d9556be8c53dd/?short_path=e2573fb#diff-e2573fb60bf11e7f54d1a89b36faa86c

@aledbf Do you think we need to adapt kubernetes that are lower than the 1.14 version? If we need to change to the previous label? Or create a separate yaml file for aks

[aledbf]

Do you think we need to adapt kubernetes that are lower than the 1.14 version?

This is one of the reasons why this was not provided in the default installation. In theory, we should have only support for the last three supported versions of Kubernetes: 1.16, 1.15 and 1.14.

I am aware that some providers are using older versions.

I only see two options:

• Remove the annotation
• Add a note on the installation page to change the annotation.

Any other option only adds confusion.

[wawa0210]

In theory, I think this annotation is necessary because Windows is officially supported after the kubernetes 1.15 version. It would be confusing to have this annotation in a hybrid cluster deployment.
I agree with your second point of view, very good practice

I try to improve the installation documentation, you can help review later.