Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use http2 in http server to support grpc without tls fix #4630 #4631

Closed
wants to merge 1 commit into from

Conversation

stamm
Copy link
Contributor

@stamm stamm commented Oct 2, 2019

What this PR does / why we need it: to handle grpc without tls

Which issue this PR fixes : fixes #4630

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @stamm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stamm
To complete the pull request process, please assign aledbf
You can assign the PR to them by writing /assign @aledbf in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf aledbf added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2019
@aledbf
Copy link
Member

aledbf commented Oct 2, 2019

@stamm there is no support for autodetection of http1.x and http2 in nginx itself. Please check
https://forum.nginx.org/read.php?29,278877,278929#msg-278929

With this change, we break http1 without tls.

#3897
#3938
#2465

@stamm
Copy link
Contributor Author

stamm commented Oct 2, 2019

@aledbf yes, I know. I use separate class for grpc and http request

@aledbf
Copy link
Member

aledbf commented Oct 2, 2019

@stamm to be clear, I am not in favor of merging this change.

@stamm
Copy link
Contributor Author

stamm commented Oct 7, 2019

ok, I think we can just patch template to not use function buildHTTPListener

@stamm stamm closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http2 option for http server
3 participants