Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform release #4613

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Terraform release #4613

merged 2 commits into from
Sep 30, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 27, 2019

What this PR does / why we need it:

Adds a new script to build the ingress controller image using Terraform in AWS with a Spot instance.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2019
@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2019

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2019
@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #4613 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4613      +/-   ##
==========================================
+ Coverage   58.67%   58.73%   +0.05%     
==========================================
  Files          88       88              
  Lines        6764     6752      -12     
==========================================
- Hits         3969     3966       -3     
+ Misses       2356     2352       -4     
+ Partials      439      434       -5
Impacted Files Coverage Δ
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️
cmd/nginx/main.go 6.53% <0%> (+0.04%) ⬆️
internal/ingress/controller/controller.go 50.61% <0%> (+0.06%) ⬆️
internal/ingress/metric/collectors/process.go 90.42% <0%> (+2.12%) ⬆️
cmd/nginx/flags.go 89.41% <0%> (+2.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de5a89...56c4a69. Read the comment docs.

@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2019
@aledbf aledbf force-pushed the terraform-release branch 2 times, most recently from b4b3f1a to 0286b2a Compare September 29, 2019 22:06
@aledbf
Copy link
Member Author

aledbf commented Sep 29, 2019

This is ready. Release 0.26.1 was generated with the content of this PR.

@aledbf aledbf merged commit 7aca7bc into kubernetes:master Sep 30, 2019
@aledbf aledbf deleted the terraform-release branch September 30, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants