-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show current reloads count, not total #4534
Conversation
Hi @ramnes. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
98a487b
to
9cf9684
Compare
/ok-to-test |
/lgtm |
@ramnes thanks! |
Codecov Report
@@ Coverage Diff @@
## master #4534 +/- ##
=======================================
Coverage 59.05% 59.05%
=======================================
Files 89 89
Lines 6811 6811
=======================================
Hits 4022 4022
Misses 2350 2350
Partials 439 439 Continue to review full report at Codecov.
|
9cf9684
to
9915a10
Compare
@aledbf my pleasure! Just realized that I forgot to push a line in the diff, so I just force pushed it. Sorry for the noise. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ramnes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: This PR improves the Grafana dashboard by displaying the reloads count related to the currently selected period rather than an overall cumulative total which doesn't really help.
Special notes for your reviewer:
It changes this:
Into this: