Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nginx unix sockets #4531

Merged
merged 2 commits into from
Sep 8, 2019
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 4, 2019

What this PR does / why we need it:

The utilization of unix sockets in nginx is not possible when we try to mount an emptyDir volume. This is a requirement when a restrictive PodSecurityPolicy is defined (read-only fs).

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4179

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@aledbf aledbf force-pushed the remove-unix-listener branch from 2838104 to 743cc73 Compare September 4, 2019 21:44
@aledbf aledbf force-pushed the remove-unix-listener branch from 743cc73 to 9ff553d Compare September 8, 2019 20:39
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2019
@aledbf aledbf removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2019
@codecov-io
Copy link

codecov-io commented Sep 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@76e2a5d). Click here to learn what that means.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4531   +/-   ##
=========================================
  Coverage          ?   59.34%           
=========================================
  Files             ?       89           
  Lines             ?     6823           
  Branches          ?        0           
=========================================
  Hits              ?     4049           
  Misses            ?     2338           
  Partials          ?      436
Impacted Files Coverage Δ
internal/ingress/controller/config/config.go 98.58% <ø> (ø)
internal/ingress/controller/nginx.go 29.44% <62.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e2a5d...6c427c7. Read the comment docs.

@aledbf aledbf merged commit ce3e3d5 into kubernetes:master Sep 8, 2019
@aledbf aledbf changed the title WIP Remove nginx unix sockets Remove nginx unix sockets Sep 8, 2019
@aledbf aledbf deleted the remove-unix-listener branch September 8, 2019 21:18
@aledbf aledbf mentioned this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run ingress-nginx on readonly fs
3 participants