-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nginx unix sockets #4531
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2838104
to
743cc73
Compare
743cc73
to
9ff553d
Compare
Codecov Report
@@ Coverage Diff @@
## master #4531 +/- ##
=========================================
Coverage ? 59.34%
=========================================
Files ? 89
Lines ? 6823
Branches ? 0
=========================================
Hits ? 4049
Misses ? 2338
Partials ? 436
Continue to review full report at Codecov.
|
What this PR does / why we need it:
The utilization of unix sockets in nginx is not possible when we try to mount an emptyDir volume. This is a requirement when a restrictive PodSecurityPolicy is defined (read-only fs).
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #4179Special notes for your reviewer: