-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openresty and third party modules #4509
Conversation
images/nginx/rootfs/build.sh
Outdated
set -o errexit | ||
set -o nounset | ||
set -o pipefail | ||
|
||
export DEBIAN_FRONTEND=noninteractive | ||
|
||
export OPENRESTY_VERSION=1.15.8.2 | ||
export OPENRESTY_VERSION=1.15.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you downgrading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there's no 1.15.8.2 release in the openresty page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrm, https://openresty.org/download/openresty-1.15.8.2.tar.gz is available though and should introduce the latest CVE patches
it's released in https://github.com/openresty/openresty/releases/tag/v1.15.8.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that tgz does not contains all the packages and when I tried to use it I got lots of errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I am waiting for a 1.17 release before continuing with this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh interesting, maybe @thibaultcha can comment on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tarball is now available at https://openresty.org/download/openresty-1.15.8.2.tar.gz. It took some time since only agentzh can upload them to openresty.org at the moment, and he was travelling when 1.15.8.2 was released. It is the same as the GitHub release tarball I uploaded a few days ago already!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thibaultcha thanks for the update.
Codecov Report
@@ Coverage Diff @@
## master #4509 +/- ##
==========================================
+ Coverage 59.05% 59.08% +0.02%
==========================================
Files 89 89
Lines 6811 6811
==========================================
+ Hits 4022 4024 +2
+ Misses 2350 2349 -1
+ Partials 439 438 -1
Continue to review full report at Codecov.
|
2af7ded
to
66516cf
Compare
@@ -525,10 +539,13 @@ apt-get remove -y --purge \ | |||
python \ | |||
xz-utils \ | |||
bc \ | |||
sensible-utils \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we introducing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that is being removed 😛
It's a transitive dependency not removed by the autoremove
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR also adds mimalloc https://github.com/microsoft/mimalloc/pulls as a drop-in replacement for malloc. This is not enabled or used by default but the gains could be better than using jemalloc.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: