Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terraform scripts to build nginx image #4484

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 23, 2019

What this PR does / why we need it:

This PD adds the required automation to build and publish the NGINX and ingress controller docker images using an AWS spot instance using terraform.

Why?

  • building in a particular workstation is not a good practice
  • anyone with write access to quay.io can build the images
  • building the NGINX images for the three platforms, amd64, arm, and arm64 take up to two hours.

Until now I was using the same approach but doing all this manually, using this gist https://gist.github.com/aledbf/e897c01f9fa285fccac04f8fd0e1047a as base

this is one of the tasks required before #4404

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2019
@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ce3e3d5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4484   +/-   ##
=========================================
  Coverage          ?   59.37%           
=========================================
  Files             ?       89           
  Lines             ?     6823           
  Branches          ?        0           
=========================================
  Hits              ?     4051           
  Misses            ?     2337           
  Partials          ?      435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3e3d5...0bd0586. Read the comment docs.

@aledbf aledbf force-pushed the terraform-build branch 2 times, most recently from f2474f7 to da0161c Compare September 8, 2019 22:35
@aledbf aledbf changed the title WIP: Add terraform scripts to build nginx image Add terraform scripts to build nginx image Sep 8, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2019
@aledbf aledbf merged commit 9eedc1b into kubernetes:master Sep 9, 2019
@aledbf aledbf deleted the terraform-build branch September 9, 2019 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants