-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nginx proxy_max_temp_file_size configuration option #4450
Add nginx proxy_max_temp_file_size configuration option #4450
Conversation
Hi @wayt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @aledbf |
@aledbf I've been told you were refactoring the configmap/annotation option stuff, feel free to postpone that if that conflict with what you are doing 👍 |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4450 +/- ##
=========================================
Coverage ? 59.32%
=========================================
Files ? 87
Lines ? 6721
Branches ? 0
=========================================
Hits ? 3987
Misses ? 2298
Partials ? 436
Continue to review full report at Codecov.
|
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, wayt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
What this PR does / why we need it:
This adds a configmap / annotations option to configure Nginx
proxy_max_temp_file_size
http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_max_temp_file_sizeWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: