Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx proxy_max_temp_file_size configuration option #4450

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

wayt
Copy link
Contributor

@wayt wayt commented Aug 15, 2019

What this PR does / why we need it:

This adds a configmap / annotations option to configure Nginx proxy_max_temp_file_size http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_max_temp_file_size

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wayt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2019
@wayt
Copy link
Contributor Author

wayt commented Aug 15, 2019

/assign @aledbf

@wayt
Copy link
Contributor Author

wayt commented Aug 15, 2019

@aledbf I've been told you were refactoring the configmap/annotation option stuff, feel free to postpone that if that conflict with what you are doing 👍

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2019
@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0b37598). Click here to learn what that means.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4450   +/-   ##
=========================================
  Coverage          ?   59.32%           
=========================================
  Files             ?       87           
  Lines             ?     6721           
  Branches          ?        0           
=========================================
  Hits              ?     3987           
  Misses            ?     2298           
  Partials          ?      436
Impacted Files Coverage Δ
internal/ingress/controller/config/config.go 98.58% <100%> (ø)
internal/ingress/controller/controller.go 47.62% <100%> (ø)
internal/ingress/annotations/proxy/main.go 59.18% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b37598...d8bd8c5. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/retest

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, wayt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/retest

1 similar comment
@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit b5fecd0 into kubernetes:master Aug 15, 2019
@wayt wayt deleted the proxy-max-temp-file-size branch August 15, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants