ewma improvements #4448
Merged
ewma improvements #4448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
ElvinEfendi
force-pushed
the
upstream-ewma-patches
branch
from
00c78a4 to
0b619dc
Compare
|
/test pull-ingress-nginx-test |
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #4448 +/- ##
=========================================
Coverage ? 59.05%
=========================================
Files ? 87
Lines ? 6643
Branches ? 0
=========================================
Hits ? 3923
Misses ? 2290
Partials ? 430
Continue to review full report at Codecov.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have been running this patch in our production clusters and have seen great improvements.
The PR changes we things
We share EWMA stats among workers now, this means workers will be able to make better load balancing decisions, faster
During endpoints change which happens multiple times during rolling deploy of a service behind ingress-nginx we won't forget all existing EWMA stats, instead we will delete only the ones that no longer exist
Again during endpoints change, new endpoints won't start with score of zero, instead we will set a seed EWMA score to them so that Nginx does not start sending too many request. This was we guarantee slow start for the new endpoints.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: