Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua-shared-dicts improvements, fixes and documentation #4446

Merged
merged 3 commits into from
Aug 15, 2019
Merged

lua-shared-dicts improvements, fixes and documentation #4446

merged 3 commits into from
Aug 15, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

  • Document the setting
  • Make sure we ignore the value when it is not an integer
  • Add more validation on the number of dictionaries and max size
  • Add more realistic test cases

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei August 15, 2019 00:25
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
@ElvinEfendi
Copy link
Member Author

/test pull-ingress-nginx-test

@ElvinEfendi
Copy link
Member Author

/retest

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

@ElvinEfendi can you adjust the size of the /configuration location using the sizes?
https://github.com/kubernetes/ingress-nginx/blob/master/rootfs/etc/nginx/template/nginx.tmpl#L584

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/retest

@ElvinEfendi
Copy link
Member Author

@ElvinEfendi can you adjust the size of the /configuration location using the sizes?

@aledbf done: https://github.com/kubernetes/ingress-nginx/pull/4446/files#diff-980db9e4b88704f12338bd074839f94eR584

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f5c5e12 into kubernetes:master Aug 15, 2019
@ElvinEfendi ElvinEfendi deleted the improve-lua-shared-dicts-setting branch August 15, 2019 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants