-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua-shared-dicts improvements, fixes and documentation #4446
lua-shared-dicts improvements, fixes and documentation #4446
Conversation
/test pull-ingress-nginx-test |
/retest |
@ElvinEfendi can you adjust the size of the /configuration location using the sizes? |
/retest |
@aledbf done: https://github.com/kubernetes/ingress-nginx/pull/4446/files#diff-980db9e4b88704f12338bd074839f94eR584 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: