Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP: Remove static SSL configuration mode #4351

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 25, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2019
@codecov-io
Copy link

codecov-io commented Jul 25, 2019

Codecov Report

Merging #4351 into master will increase coverage by 2.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4351      +/-   ##
==========================================
+ Coverage   58.47%   60.99%   +2.52%     
==========================================
  Files          87       89       +2     
  Lines        6528     7953    +1425     
==========================================
+ Hits         3817     4851    +1034     
- Misses       2282     2601     +319     
- Partials      429      501      +72
Impacted Files Coverage Δ
internal/ingress/sslcert.go 25% <0%> (-25%) ⬇️
cmd/nginx/flags.go 83.75% <0%> (-5.66%) ⬇️
internal/ingress/annotations/annotations.go 78.4% <0%> (-2.48%) ⬇️
internal/ingress/controller/config/config.go 97.91% <0%> (-0.66%) ⬇️
internal/ingress/types.go 0% <0%> (ø) ⬆️
internal/ingress/annotations/mirror/main.go 100% <0%> (ø)
internal/ingress/annotations/fastcgi/main.go 100% <0%> (ø)
internal/ingress/controller/template/template.go 84.54% <0%> (+0.61%) ⬆️
internal/ingress/metric/collectors/process.go 90.42% <0%> (+2.12%) ⬆️
internal/ingress/controller/store/backend_ssl.go 58.73% <0%> (+2.15%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f062d...374045d. Read the comment docs.

@aledbf aledbf force-pushed the static-mode branch 2 times, most recently from eff2dbf to 12b5dd8 Compare July 25, 2019 03:52
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6948cd7 into kubernetes:master Aug 15, 2019
@aledbf aledbf deleted the static-mode branch September 18, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants