Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [$proxy_alternative_upstream_name] #4333

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

judexzhu
Copy link
Contributor

#4246

What this PR does / why we need it:

update the log-format.md doc

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

After upgrade to 0.25.0, the log format has been changed, [$proxy_alternative_upstream_name] has been added but not document explained it right now.

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Welcome @judexzhu!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @judexzhu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2019
@judexzhu
Copy link
Contributor Author

I signed it

@aledbf
Copy link
Member

aledbf commented Jul 19, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2019
@codecov-io
Copy link

codecov-io commented Jul 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@589c9a2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4333   +/-   ##
=========================================
  Coverage          ?   58.48%           
=========================================
  Files             ?       87           
  Lines             ?     6528           
  Branches          ?        0           
=========================================
  Hits              ?     3818           
  Misses            ?     2283           
  Partials          ?      427

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589c9a2...5e64b68. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jul 19, 2019

/check-cla

@judexzhu
Copy link
Contributor Author

@aledbf Sorry for the inconvenient, I did sign the CLA with my github account , and dont know why the CLA cannot pass the test
image
Anything I should go and check?

Thank you

@aledbf
Copy link
Member

aledbf commented Jul 19, 2019

@judexzhu some times, it just requires more time to pass the validation. Let's wait.

@aledbf
Copy link
Member

aledbf commented Jul 19, 2019

/check-cla

1 similar comment
@judexzhu
Copy link
Contributor Author

/check-cla

@aledbf aledbf closed this Jul 21, 2019
@aledbf aledbf reopened this Jul 21, 2019
@aledbf
Copy link
Member

aledbf commented Jul 21, 2019

/test pull-ingress-nginx-test

@aledbf
Copy link
Member

aledbf commented Jul 21, 2019

@judexzhu please check the Details link. Something is wrong with your github username, email or the git configuration is not the correct.

@aledbf
Copy link
Member

aledbf commented Jul 21, 2019

/test pull-ingress-nginx-e2e-1-12

@judexzhu
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 22, 2019
@aledbf
Copy link
Member

aledbf commented Jul 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, judexzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@aledbf
Copy link
Member

aledbf commented Jul 22, 2019

Thanks!

@k8s-ci-robot k8s-ci-robot merged commit 29fa747 into kubernetes:master Jul 22, 2019
@judexzhu judexzhu deleted the patch-1 branch July 23, 2019 03:24
@Renz2018
Copy link

@judexzhu what is different between proxy_alternative_upstream_name and proxy_upstream_name?

@ElvinEfendi
Copy link
Member

@Renz2018 when a request is proxied to canary backend then proxy_alternative_upstream_name will be set to corresponding canary backend. proxy_upstream_name always logs main backend.

@Renz2018
Copy link

@ElvinEfendi Thanks for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants