-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [$proxy_alternative_upstream_name] #4333
Conversation
Welcome @judexzhu! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @judexzhu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4333 +/- ##
=========================================
Coverage ? 58.48%
=========================================
Files ? 87
Lines ? 6528
Branches ? 0
=========================================
Hits ? 3818
Misses ? 2283
Partials ? 427 Continue to review full report at Codecov.
|
/check-cla |
@aledbf Sorry for the inconvenient, I did sign the CLA with my github account , and dont know why the CLA cannot pass the test Thank you |
@judexzhu some times, it just requires more time to pass the validation. Let's wait. |
/check-cla |
1 similar comment
/check-cla |
/test pull-ingress-nginx-test |
@judexzhu please check the |
/test pull-ingress-nginx-e2e-1-12 |
/check-cla |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, judexzhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! |
@judexzhu what is different between proxy_alternative_upstream_name and proxy_upstream_name? |
@Renz2018 when a request is proxied to canary backend then |
@ElvinEfendi Thanks for your reply! |
#4246
What this PR does / why we need it:
update the log-format.md doc
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #After upgrade to 0.25.0, the log format has been changed, [$proxy_alternative_upstream_name] has been added but not document explained it right now.
Special notes for your reviewer: