-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dev-env.sh script work on Linux #4290
Conversation
Welcome @mdonkers! |
Hi @mdonkers. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4290 +/- ##
=========================================
Coverage ? 58.31%
=========================================
Files ? 87
Lines ? 6472
Branches ? 0
=========================================
Hits ? 3774
Misses ? 2272
Partials ? 426 Continue to review full report at Codecov.
|
Please change the title. The script dev-env.sh works on Linux. Something like |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, mdonkers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently the
dev-env.sh
script, used for deploying to a local Minikube, only works on MacOS unless bothkubectl
andkustomize
are installed.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #This PR works somewhat to a more supported setup by just using
kubectl
when that is available, since the latest (> v1.14) haskustomize
by default included. So no separatekustomize
tool needs to be installed via Homebrew. So this lowers also the requirements for Linux, as onlykubectl
needs to be present on the system already.Special notes for your reviewer:
The
kubectl kustomize
command does not have the option to set fields in an existingkustomize.yaml
file. Tried to use overlays within the${ROOT}
directory but that leads to 'cycle detected' errors. So instead opted to usesed
to replace variables within thekustomize.yaml
file directly as thekustomize
command itself would do.