Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.25.0 #4275

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Release 0.25.0 #4275

merged 1 commit into from
Jul 8, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 5, 2019 •
edited
Loading

Test image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:dev

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2019
@aledbf
Copy link
Member Author

aledbf commented Jul 5, 2019

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and ElvinEfendi July 5, 2019 00:32
@codecov-io
Copy link

codecov-io commented Jul 5, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7c297e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4275   +/-   ##
=========================================
  Coverage          ?   58.23%           
=========================================
  Files             ?       87           
  Lines             ?     6489           
  Branches          ?        0           
=========================================
  Hits              ?     3779           
  Misses            ?     2282           
  Partials          ?      428

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c297e0...c681501. Read the comment docs.

@aledbf aledbf force-pushed the release-025 branch 2 times, most recently from 0806c05 to 73c5cc4 Compare July 5, 2019 02:23
@aledbf
Copy link
Member Author

aledbf commented Jul 5, 2019

/test pull-ingress-nginx-test

@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2019
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member Author

aledbf commented Jul 8, 2019

/test pull-ingress-nginx-test

@k8s-ci-robot k8s-ci-robot merged commit 1387f7b into kubernetes:master Jul 8, 2019
@aledbf aledbf deleted the release-025 branch July 8, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @codecov-io @ElvinEfendi @k8s-ci-robot