-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test cases for balancer lua module #4187
Add unit test cases for balancer lua module #4187
Conversation
Welcome @s-shirayama! |
Hi @s-shirayama. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/test pull-ingress-nginx-test |
Codecov Report
@@ Coverage Diff @@
## master #4187 +/- ##
=========================================
+ Coverage 57.66% 58.6% +0.93%
=========================================
Files 87 87
Lines 6463 6950 +487
=========================================
+ Hits 3727 4073 +346
- Misses 2306 2409 +103
- Partials 430 468 +38
Continue to review full report at Codecov.
|
Hi, @aledbf |
@s-shirayama review from @ElvinEfendi |
@s-shirayama I love these kind of PRs - thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, s-shirayama The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds unit test cases for balancer.lua's route_to_alternative_balancer() function.
Since I'm planning to fix #4028 and add more test cases for the change, I added test cases for existing logic of target function.
Which issue this PR fixes *(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
Related with #4028 (but not fix it)Special notes for your reviewer:
N/A